Closed
Bug 1240063
Opened 9 years ago
Closed 9 years ago
disable mozilla/balanced-listeners rule for devtools
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(firefox46 fixed)
RESOLVED
FIXED
Firefox 46
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
People
(Reporter: tromey, Assigned: tromey)
References
Details
Attachments
(1 file)
|
864 bytes,
patch
|
pbro
:
review+
|
Details | Diff | Splinter Review |
The balanced-listeners eslint rule gives false positives in many places
and devtools and at the same time doesn't seem to catch many bugs.
I think this rule should be disabled for devtools.
|
Assignee | |
Comment 1•9 years ago
|
||
|
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8708476 [details] [diff] [review]
remove balanced-listener rule from devtools .eslintrc
As discussed on irc.
Attachment #8708476 -
Flags: review?(pbrosset)
|
||
Updated•9 years ago
|
Attachment #8708476 -
Flags: review?(pbrosset) → review+
|
||
Comment 4•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
|
||
Comment 5•9 years ago
|
||
[bugday-20160323]
Status: RESOLVED,FIXED -> UNVERIFIED
Comments:
STR: Not clear.
Developer specific testing
Component:
Name Firefox
Version 46.0b9
Build ID 20160322075646
Update Channel beta
User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS Windows 7 SP1 x86_64
Expected Results:
Developer specific testing
Actual Results:
As expected
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•